RESOLVED FIXED 18916
make_names.pl --factory needs to support custom c++ guard 
https://bugs.webkit.org/show_bug.cgi?id=18916
Summary make_names.pl --factory needs to support custom c++ guard
Julien Chaffraix
Reported 2008-05-06 16:42:14 PDT
Currently factories generated by make_names are protected by "ENABLE(SVG)" which should not be hardcoded but left as a command line option.
Attachments
First try (6.80 KB, patch)
2008-05-06 16:46 PDT, Julien Chaffraix 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2008-05-06 16:46:01 PDT
Created attachment 20990 [details] First try
Eric Seidel (no email)
Comment 2 2008-05-06 19:05:21 PDT
Comment on attachment 20990 [details] First try Looks good to me. You can avoid checking guardFactory against "" everywhere by just inverting the if. I think that "" is false in perl. If its not, then you can do the "" check at the top, and assign guardFactory to some value which is false, like null. it's OK as is, or with the further "" check cleanup. I don't need to see the patch again before you land. r=me.
Julien Chaffraix
Comment 3 2008-05-08 17:07:45 PDT
> You can avoid checking guardFactory against "" everywhere by just inverting the > if. I think that "" is false in perl. If its not, then you can do the "" > check at the top, and assign guardFactory to some value which is false, like > null. > I got confused by using 'unless' which is why I needed to check against the empty string. I switched to 'if' and cleaned up the patch as Eric suggested. Committed in r32989.
Note You need to log in before you can comment on or make changes to this bug.