Bug 18906 - [GTK] Fix varargs terminator in g_build_filename()
Summary: [GTK] Fix varargs terminator in g_build_filename()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-06 04:18 PDT by Gwenole Beauchesne
Modified: 2008-05-06 13:21 PDT (History)
2 users (show)

See Also:

Attachments
Fix varargs terminator (994 bytes, patch)
2008-05-06 04:19 PDT, Gwenole Beauchesne 		alp: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gwenole Beauchesne 2008-05-06 04:18:47 PDT 
g_build_filename() is NULL terminated, or (void *)0 with your coding style if you prefer.

It currently works by luck on Linux/x86_64 because g_build_filename() args are <= 6, so they are all passed through registers.
Comment 1 Gwenole Beauchesne 2008-05-06 04:19:29 PDT 
Created attachment 20982 [details]
Fix varargs terminator
Comment 2 Alp Toker 2008-05-06 13:20:31 PDT 
Comment on attachment 20982 [details]
Fix varargs terminator

r=me

The patch utility didn't like this, I had to hand apply it. Please check the formatting of the ChangeLog entry too next time.

Thanks
Comment 3 Alp Toker 2008-05-06 13:21:07 PDT 
Landed in r32913.