Bug 18905 – [GTK] Fix build with older pango (1.14.8)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Gwenole Beauchesne]

WebKit doesn't build with older pango, e.g. 1.14.8 from Debian/etch.

Please either require pango >= 1.15.2 or apply a patch similar to the attachment.

[Gwenole Beauchesne]

Created attachment 20981 [details]
Fix build with older pango

This is a literal copy for pango sources.

Note that the PANGO_VERSION_CHECK() macro appeared along with the missing functions pango_layout_get_line_readonly() and pango_language_get_default(). i.e. I am not testing for !PANGO_VERSION_CHECK(1,15,2).

An alternative could be to AC_CHECK_FUNCS(pango_layout_get_line_readonly) and dependent on the generated HAVE_FUNCTION thing.

[Jan Alonzo]

Hi Gwenole. Is your patch for review? If so, please set the review flag to '+' so reviewers will notice your patch.

[Pierre-Luc Beaudoin]

Actually, if the patch is ready to be reviewed, you should set the review flag to "?".  Then, once it has been reviewed, the reviewer will set the flag to '+' or '-' depending on the outcome.

[Jan Alonzo]

Comment on attachment 20981 [details]
Fix build with older pango

setting the patch for review...

[Eric Seidel (no email)]

Comment on attachment 20981 [details]
Fix build with older pango

I think it's cleaner to pull in code from other libraries in separate headers/cpp files.  That makes it much easier (in my mind) to justify the WebKit style violation, if the whole file is of that separate style.

[Eric Seidel (no email)]

Comment on attachment 20981 [details]
Fix build with older pango

Tis fine though.

[Jan Alonzo]

Landed in r36990. Thanks!