Bug 18704 – [gtk] cannot type letters with dead keys in textarea

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[arno.]

Hi,
I'm using some dead keys to type french letters. For exemple, I have a key mapped to dead_acute. I type that key + e to get é.
 
That works fine in <input> fields, but in <textarea>s, I cannot get accentuated letters. For <input>s, keydown events are passed to document()->frame()->doTextFieldCommandFromEvent() but not in textarea. That function will then call gtk_im_context_filter_keypress with gtk frontend.

I'll attach a patch to call that function also for <textearea>s. That seems to fix the problem on gtk. That may also enable other input method on textareas.

[arno.]

Created attachment 20780 [details]
calls doTextFieldCommandFromEvent on keydown for textareas

[Alp Toker]

Upgrading to P1. ap, any thoughts on whether this patch is correct?

[Alexey Proskuryakov]

Comment on attachment 20780 [details]
calls doTextFieldCommandFromEvent on keydown for textareas

WebEditorClient::doTextFieldCommandFromEvent() is really only about text fields, which textareas are not. Invoking it for text areas would break Safari on the Mac, besides not being true to its name.

We could of course add another client method just for textareas, but processing dead keys in element default handlers doesn't seem right to me in general, it is a much lower level task. Perhaps WebEditorClient::handleKeyboardEvent() would be more appropriate.

[Alp Toker]

Created attachment 21390 [details]
Input method fixes

[Alexey Proskuryakov]

Comment on attachment 21390 [details]
Input method fixes

Obviously, I'm not an expert at GTK input methods, but this looks absolutely reasonable, r=me.

I would expect that this doesn't dispatch text input events in a manner compatible with IE and Safari though.

[Alp Toker]

Fix landed in r34176. Thanks