http/tests/security/cross-frame-access-call.html contains a test for cross domain violation on "window.open.call()", by checking for a return value of undefined. However since popups are disabled, window.open will return undefined regardless.
Created attachment 20636 [details] add layoutTestController.setCanOpenWindows(true)
Comment on attachment 20636 [details] add layoutTestController.setCanOpenWindows(true) Thanks for the patch! You should leave the "requestee" field blank in most cases when putting a patch up for review. You'll need to create a ChangeLog entry. See <http://webkit.org/coding/contributing.html> for information on how to prepare and submit a patch. Have you verified that the test still passes? r- so that a ChangeLog can be added.
Created attachment 20673 [details] add layoutTestController.setCanOpenWindows(true) Sorry about that aroben! Fixed, new patch uploaded. I ran the layout test, and it passes. I did have to change a line number in the expected output though, since this patch added two lines.
Comment on attachment 20673 [details] add layoutTestController.setCanOpenWindows(true) +2008-04-18 Eric Roman <minatoar@gmail.com> + + Reviewed by NOBODY (OOPS!). + + * http/tests/security/cross-frame-access-call-expected.txt: Increase a console line number (since added two lines) + * http/tests/security/cross-frame-access-call.html: Enable popups for this layout test. The test checks that window.open is returns undefined (same-domain enforcement), however unless popups are enabled it returns undefined regardless. + It's customary to list the bug title and URL of the bug you're fixing in your ChangeLog entry (though I think unfortunately this is not mentioned on our website anywhere). Whomever lands this patch can add that for you. r=me. Thanks!
Committed revision 34447.