Bug 18508 - SquirrelFish crashes due to bad scope chain on some SunSpider tests
Summary: SquirrelFish crashes due to bad scope chain on some SunSpider tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-15 01:07 PDT by Maciej Stachowiak
Modified: 2008-04-24 17:52 PDT (History)
0 users

See Also:

Attachments
the fix (26.86 KB, patch)
2008-04-15 01:46 PDT, Maciej Stachowiak 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2008-04-15 01:07:59 PDT 
Some SunSpider tests (3d-raytrace, string-unpack-code) crash due to keeping around a ScopeChain* that points into the register file, but the register file can move in memory when it grows.
Comment 1 Maciej Stachowiak 2008-04-15 01:09:44 PDT 
A possible solution is to pass around ScopeChainNode* instead.
Comment 2 Maciej Stachowiak 2008-04-15 01:46:08 PDT 
Created attachment 20548 [details]
the fix
Comment 3 Oliver Hunt 2008-04-15 01:54:59 PDT 
Comment on attachment 20548 [details]
the fix

r=me
Comment 4 Cameron Zwarich (cpst) 2008-04-24 17:52:43 PDT 
Landed in r31897.