Bug 18471 - Fix WebDownload.cpp compile problems for cairo/curl build
Summary: Fix WebDownload.cpp compile problems for cairo/curl build
Status: RESOLVED DUPLICATE of bug 23092
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks: 17730
  Show dependency tree / graph
 
Reported: 2008-04-13 21:58 PDT by Daniel Zucker
Modified: 2009-08-11 22:47 PDT (History)
2 users (show)

See Also:

Attachments
divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp (118.18 KB, patch)
2008-04-13 21:59 PDT, Daniel Zucker 		aroben: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Zucker 2008-04-13 21:58:25 PDT 
This patch replaces WebDownload.cpp with WebDownloadCFNet.cpp and WebDownloadCurl.cpp.  WebDownloadCFNet.cpp is unchanged.  WebDownloadCurl.cpp removes some function implementations and replaces them with stubs.  WebKit.vcproj is also modified to include/exclude the appropriate files from the appropriate build configurations.
Comment 1 Daniel Zucker 2008-04-13 21:59:08 PDT 
Created attachment 20518 [details]
divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp
Comment 2 Adam Roben (:aroben) 2008-04-14 08:11:23 PDT 
Comment on attachment 20518 [details]
divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp

It looks like this patch has a mixture of spaces and tabs in it. Please only use 4 spaces for indentation.

I think we'd ultimately be better served by moving the concept of a "download" to WebCore and having the platform differences reside at that level. Having two whole implementations of WebDownload doesn't feel like the right solution to me.
Comment 3 Brent Fulgham 2009-08-11 22:47:50 PDT 
This work (or a facsimile of this) is now part of WebKit.  Marking this as a duplicate and closing.

*** This bug has been marked as a duplicate of bug 23092 ***