Bug 18405 - [GTK] Property setters do not call g_object_notify()
Summary: [GTK] Property setters do not call g_object_notify()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-10 08:34 PDT by Marco Barisione
Modified: 2008-06-15 07:42 PDT (History)
1 user (show)

See Also:

Attachments
Add missing g_object_notify in WebKitWebView (1.15 KB, patch)
2008-06-15 07:13 PDT, Christian Dywan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Barisione 2008-04-10 08:34:34 PDT 
If a property is set using the _set_foobar() method then the notify::foobar method is not emitted.
We should add a call to g_object_notify to every setter, if possible emitting the signal only if the new value is different from the old one.
Comment 1 Christian Dywan 2008-06-15 07:13:08 PDT 
Created attachment 21711 [details]
Add missing g_object_notify in WebKitWebView

There are in fact three cases in WebKitWebView where g_object_notify is missing, this patch fixes them.
Comment 2 Christian Dywan 2008-06-15 07:42:19 PDT 
Comment on attachment 21711 [details]
Add missing g_object_notify in WebKitWebView

Committed in revision 34571.