Bug 18342 – Add logging to HTTP soup backend

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Xan Lopez]

Patch attached.

[Xan Lopez]

Created attachment 20381 [details]
0001-Add-logging-to-http-soup-backend.patch

[Dan Winship]

You should unref the logger after attaching it to the session. (It doesn't really matter since the session is never destroyed anyway, so it doesn't actually cause a leak, but...)

Any reason you used two environment variables instead of just one?

[Xan Lopez]

(In reply to comment #2)
> You should unref the logger after attaching it to the session. (It doesn't
> really matter since the session is never destroyed anyway, so it doesn't
> actually cause a leak, but...)

Right, actually thought about that after sending the patch... fixed in the next patch anyway.

> 
> Any reason you used two environment variables instead of just one?
> 

Not really, might be handy if it could be changed at run-time, but I guess there is no point right now (and you could still manage with one variable anyway).

[Xan Lopez]

Created attachment 20382 [details]
0001-Add-logging-to-http-soup-backend.patch

[Xan Lopez]

Created attachment 20383 [details]
0001-Add-logging-to-http-soup-backend.patch

Fix ChangeLog

[Mark Rowe (bdash)]

What is the behaviour if I pass a value for WEBKIT_SOUP_LOGGING outside of the range 0-3?

[Xan Lopez]

(In reply to comment #6)
> What is the behaviour if I pass a value for WEBKIT_SOUP_LOGGING outside of the
> range 0-3?
> 

As far as I understand the code the value is checked progressively against 0/1/2 and if it's not equal it's assumed to be the maximum verbosity value. We can clamp it here or, maybe better, soup should warn about invalid values.

[Alp Toker]

Comment on attachment 20383 [details]
0001-Add-logging-to-http-soup-backend.patch

Think this is fine, no need to clamp. This will help debug the soup backend, r=me

[Alp Toker]

Landed in r31792.