WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
18331
WebCore/svg/SVGAnimateMotionElement.cpp doesn't build when foreign objects are not enabled
https://bugs.webkit.org/show_bug.cgi?id=18331
Summary
WebCore/svg/SVGAnimateMotionElement.cpp doesn't build when foreign objects ar...
Mike Hommey
Reported
2008-04-06 11:33:05 PDT
The summary says it all: when enabling SVG animations, WebCore/svg/SVGAnimateMotionElement.cpp fails to build when SVG foreign objects are not enabled.
Attachments
patch
(644 bytes, patch)
2008-04-06 11:34 PDT
,
Mike Hommey
rwlbuis
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mike Hommey
Comment 1
2008-04-06 11:34:21 PDT
Created
attachment 20369
[details]
patch
Rob Buis
Comment 2
2008-04-06 12:51:00 PDT
Comment on
attachment 20369
[details]
patch You should use #if ENABLE(SVG_FOREIGN_OBJECT) instead, and provide a ChangeLog.
Eric Seidel (no email)
Comment 3
2008-04-13 22:25:01 PDT
Final patch:
http://paste.lisp.org/display/59101
Landed as
r31856
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug