Bug 18331 - WebCore/svg/SVGAnimateMotionElement.cpp doesn't build when foreign objects are not enabled
Summary: WebCore/svg/SVGAnimateMotionElement.cpp doesn't build when foreign objects ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-06 11:33 PDT by Mike Hommey
Modified: 2008-04-13 22:25 PDT (History)
0 users

See Also:

Attachments
patch (644 bytes, patch)
2008-04-06 11:34 PDT, Mike Hommey 		rwlbuis: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Hommey 2008-04-06 11:33:05 PDT 
The summary says it all: when enabling SVG animations, WebCore/svg/SVGAnimateMotionElement.cpp fails to build when SVG foreign objects are not enabled.
Comment 1 Mike Hommey 2008-04-06 11:34:21 PDT 
Created attachment 20369 [details]
patch
Comment 2 Rob Buis 2008-04-06 12:51:00 PDT 
Comment on attachment 20369 [details]
patch

You should use 
#if ENABLE(SVG_FOREIGN_OBJECT)

instead, and provide a ChangeLog.
Comment 3 Eric Seidel (no email) 2008-04-13 22:25:01 PDT 
Final patch:
http://paste.lisp.org/display/59101
Landed as r31856