Bug 18302 – DumpRenderTree Resources out of Order causes failures in tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Simon Hollingshead]

One test, the webarchive/test-css-import.html one, appears to fail on my system.  This is not because anything is incorrect, but simply because the files are received in the opposite order as to how they are expected.  This occurs on some systems only, such as within chat:
<bradee-oh> ah!  on my Mac Pro I get the out-of-orderness, but not on my MacBookPro

[Simon Hollingshead]

Created attachment 20314 [details]
Example of the diffs within a test where two resources are recieved in the opposite order.

Added example from Dump Render Tree.

[Simon Hollingshead]

Comment on attachment 20314 [details]
Example of the diffs within a test where two resources are recieved in the opposite order.

Placed space in description where accidentally omitted previously.

[Brady Eidson]

Created attachment 20408 [details]
Proposed fix, and 3 updated layout tests

Comment on attachment 20408 [details]
Proposed fix, and 3 updated layout tests

+static NSInteger resourceURLSort(id resource1, id resource2, void *reverse)

I'd really prefer the name compareResourceURLs.

+        if (NSArray* newSubresource = [subresources sortedArrayUsingFunction:resourceURLSort context:&reverseSort])

The * should go next to newSubresource, which I'd call "newSubresourceS" or "sortedSubresources".

Since the compare function does not use the context argument ("reverse"), just pass 0, and don't call it "reverse".

r=me but please try to address some of my comments

[Brady Eidson]

Landed in 31722