Bug 18218 – [Gtk] segfault when clicking on a disabled button

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Zoltan Dome]

Webkit segfaults when clicking on a disabled button.

This only happens when the disabled button is on the first page loaded by the engine AND is the first thing clicked on.

So, for example, if I start GtkLauncher with a test-file and click the button, it crashes, but it doesn't crash if I click somewhere else on the page first.

[Zoltan Dome]

Created attachment 20212 [details]
test file for bug

[Julien Chaffraix]

Confirmed on ToT.

The cause is in webkit_web_view_button_release_event (webkitwebview.cpp) when focusFrame is null. There is no null check so we call one of focusFrame's methods which results in a crash.

[Jan Alonzo]

Created attachment 20511 [details]
Add a null check before using the focused frame

The patch checks for a null focusedFrame before calling the event handler. Thanks jchaffraix for the hint.

[Kalle Vahlman]

Apparently this bug is also an issue with having a "mousedown" event handler that calls event.preventDefault().

I tested Jan's patch, and it fixes things for both cases.

[Alp Toker]

Comment on attachment 20511 [details]
Add a null check before using the focused frame

r-

The correct fix is to use the main frame for mouse events since it has the logic to bubble the event to the correct owner.

I'll take care of this one.

[Alp Toker]

(Different) fix landed in r32203.

Thanks for tracking this issue Jan!