Bug 18213 - Add support for dot notation and object literals to SquirrelFish
Summary: Add support for dot notation and object literals to SquirrelFish
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-29 19:11 PDT by Cameron Zwarich (cpst)
Modified: 2008-03-30 21:46 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (11.69 KB, patch)
2008-03-29 19:12 PDT, Cameron Zwarich (cpst) 		oliver: review+
Details | Formatted Diff | Diff
Revised proposed patch (8.62 KB, patch)
2008-03-29 22:22 PDT, Cameron Zwarich (cpst) 		no flags Details | Formatted Diff | Diff
Revised proposed patch (8.08 KB, patch)
2008-03-29 22:29 PDT, Cameron Zwarich (cpst) 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-03-29 19:11:03 PDT 
The next post has the patch.
Comment 1 Cameron Zwarich (cpst) 2008-03-29 19:12:31 PDT 
Created attachment 20204 [details]
Proposed patch

Here's the patch. Getters and setters don't actually work because FuncExprNode isn't implemented.
Comment 2 Cameron Zwarich (cpst) 2008-03-29 19:17:22 PDT 
Doh, this patch hits a random GCC performance regression on an empty for loop. I'll see if it's fixable.
Comment 3 Cameron Zwarich (cpst) 2008-03-29 22:22:34 PDT 
Created attachment 20207 [details]
Revised proposed patch

The performance regression was caused by the getters and setters. It might still be possible to fight with GCC to beat the regression, but I'll leave it for now.
Comment 4 Cameron Zwarich (cpst) 2008-03-29 22:29:10 PDT 
Created attachment 20208 [details]
Revised proposed patch

Oops. I left emitDefineGetter() and emitDefineSetter() in CodeGenerator.h. Here's a fixed patch.
Comment 5 Maciej Stachowiak 2008-03-30 14:02:56 PDT 
Comment on attachment 20208 [details]
Revised proposed patch

r=me
Comment 6 Cameron Zwarich (cpst) 2008-03-30 21:46:54 PDT 
Landed in r31443.