Bug 18195 - Paths for Cairo-based WebKit Targets Finds Wrong ResourceRequest.h
Summary: Paths for Cairo-based WebKit Targets Finds Wrong ResourceRequest.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-28 15:58 PDT by Brent Fulgham
Modified: 2008-04-03 15:53 PDT (History)
1 user (show)

See Also:

Attachments
Small patch to correct Visual Studio paths for Curl build. (12.69 KB, patch)
2008-03-28 16:20 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Revised patch against TOT (12.80 KB, patch)
2008-03-31 15:16 PDT, Brent Fulgham 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2008-03-28 15:58:41 PDT 
The revisions I made to Bug 17985 to match the TOT project file was not complete.  The CFNetwork header paths were re-included in the Release_Cairo and Debug_Cairo project files when I merged in the latest project file changes.

This patch corrects this error.
Comment 1 Brent Fulgham 2008-03-28 16:20:01 PDT 
Created attachment 20169 [details]
Small patch to correct Visual Studio paths for Curl build.
Comment 2 Alp Toker 2008-03-31 08:16:38 PDT 
This does not apply any more unfortunately.
Comment 3 Brent Fulgham 2008-03-31 15:16:20 PDT 
Created attachment 20263 [details]
Revised patch against TOT

Revised patch so that line offsets are against TOT.
Comment 4 Darin Adler 2008-04-02 02:32:43 PDT 
Comment on attachment 20263 [details]
Revised patch against TOT

Looks fine.

Next time, please delete the "WARNING: NO TEST CASES ADDED OR CHANGED" line if that's not needed.

This entire thing comes from the questionable practice of having many files with the same filename!
Comment 5 Matt Lilek 2008-04-03 15:53:11 PDT 
Landed in r31609