Bug 18192 – Squirrelfish needs support for break and continue

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Oliver Hunt]

Task tracking bug

[Oliver Hunt]

Created attachment 20165 [details]
Implementate support for continue and goto

[Geoffrey Garen]

+        Vector<LoopContext> m_loopsContextStack;

How about calling this "m_loopContextStack"?

+CodeGenerator::LoopContext* CodeGenerator::scopeForIdentifier(const Identifier& label)

"Scope" is very specifically tied to variable resolution in JavaScript. How about naming this function "loopContextForIdentifier"?

+    LoopContext* scope = scopeForIdentifier(label);

And calling this variable "loopContext"?

+LabelID* CodeGenerator::getLabelForContinue(const Identifier& label)
+{
+    LoopContext* scope = scopeForIdentifier(label);
+    return scope ? scope->continueTarget : 0;
+}
+
+LabelID* CodeGenerator::getLabelForBreak(const Identifier& label)

Our style is to omit the "get" from these function names.

Looks good. r=me

[Geoffrey Garen]

I think you can change this:

+    LoopContext scope = { labels, continueTarget, breakTarget };
+    m_loopsContextStack.append(scope);

to this:

m_loopsContextStack.append({ labels, continueTarget, breakTarget });

[Oliver Hunt]

Comment on attachment 20165 [details]
Implementate support for continue and goto

reviewed by Geoff

[Oliver Hunt]

Landed r31411