Bug 18148 - REGRESSION(r31246): Cairo backend build broken
Summary: REGRESSION(r31246): Cairo backend build broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2008-03-27 10:04 PDT by Brent Fulgham
Modified: 2008-03-31 14:51 PDT (History)
0 users

See Also:

Attachments
Correct build regression (2.47 KB, patch)
2008-03-27 11:04 PDT, Brent Fulgham 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2008-03-27 10:04:42 PDT 
Changes in r31246 to GraphicsContext were not carried over to the Cairo version, resulting in a broken build.

* Changes to GraphicsContextCGWin.cpp were not made to GraphicsContextCairoWin.cpp (specifically the changes to the method signatures for getWindowsContext and releaseWindowsContext.

Some analog to the new 'createPathForGlyph' may be necessary, but it is not immediately obvious to me how this should work with Cairo.
Comment 1 Brent Fulgham 2008-03-27 11:04:51 PDT 
Created attachment 20129 [details]
Correct build regression

Patch to correct build regression due to change in GraphicsContext method signature changes.
Comment 2 Maciej Stachowiak 2008-03-28 10:15:05 PDT 
Comment on attachment 20129 [details]
Correct build regression

r=me
Comment 3 Julien Chaffraix 2008-03-31 14:51:23 PDT 
Closing bug as it has been committed in r31403.