Bug 18127 - Add support for more node types to SquirrelFish.
Summary: Add support for more node types to SquirrelFish.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-26 17:13 PDT by Cameron Zwarich (cpst)
Modified: 2008-03-26 21:43 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (37.39 KB, patch)
2008-03-26 17:16 PDT, Cameron Zwarich (cpst) 		no flags Details | Formatted Diff | Diff
Revised proposed patch (39.22 KB, patch)
2008-03-26 17:44 PDT, Cameron Zwarich (cpst) 		ggaren: review+
Details | Formatted Diff | Diff
Revised proposed patch (37.44 KB, patch)
2008-03-26 19:42 PDT, Cameron Zwarich (cpst) 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-03-26 17:13:59 PDT 
I've written support for more node types. I figured I should get it reviewed before I go any further.
Comment 1 Cameron Zwarich (cpst) 2008-03-26 17:16:34 PDT 
Created attachment 20105 [details]
Proposed patch
Comment 2 Cameron Zwarich (cpst) 2008-03-26 17:44:33 PDT 
Created attachment 20108 [details]
Revised proposed patch

Added copyright information.
Comment 3 Geoffrey Garen 2008-03-26 18:28:54 PDT 
Comment on attachment 20108 [details]
Revised proposed patch

As discussed on IRC, please factor out a printBinaryOp function for use by CodeBlock::dump.

r=me
Comment 4 Cameron Zwarich (cpst) 2008-03-26 19:42:14 PDT 
Created attachment 20113 [details]
Revised proposed patch

Here it is with your request refactoring.
Comment 5 Geoffrey Garen 2008-03-26 19:43:22 PDT 
Comment on attachment 20113 [details]
Revised proposed patch

r=me
Comment 6 Geoffrey Garen 2008-03-26 21:43:57 PDT 
Committed revision 31362.