RESOLVED FIXED 18127
Add support for more node types to SquirrelFish. 
https://bugs.webkit.org/show_bug.cgi?id=18127
Summary Add support for more node types to SquirrelFish.
Cameron Zwarich (cpst)
Reported 2008-03-26 17:13:59 PDT
I've written support for more node types. I figured I should get it reviewed before I go any further.
Attachments
Proposed patch (37.39 KB, patch)
2008-03-26 17:16 PDT, Cameron Zwarich (cpst) 		no flags
DetailsFormatted DiffDiff
Revised proposed patch (39.22 KB, patch)
2008-03-26 17:44 PDT, Cameron Zwarich (cpst) 		ggaren: review+
DetailsFormatted DiffDiff
Revised proposed patch (37.44 KB, patch)
2008-03-26 19:42 PDT, Cameron Zwarich (cpst) 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-03-26 17:16:34 PDT
Created attachment 20105 [details] Proposed patch
Cameron Zwarich (cpst)
Comment 2 2008-03-26 17:44:33 PDT
Created attachment 20108 [details] Revised proposed patch Added copyright information.
Geoffrey Garen
Comment 3 2008-03-26 18:28:54 PDT
Comment on attachment 20108 [details] Revised proposed patch As discussed on IRC, please factor out a printBinaryOp function for use by CodeBlock::dump. r=me
Cameron Zwarich (cpst)
Comment 4 2008-03-26 19:42:14 PDT
Created attachment 20113 [details] Revised proposed patch Here it is with your request refactoring.
Geoffrey Garen
Comment 5 2008-03-26 19:43:22 PDT
Comment on attachment 20113 [details] Revised proposed patch r=me
Geoffrey Garen
Comment 6 2008-03-26 21:43:57 PDT
Committed revision 31362.
Note You need to log in before you can comment on or make changes to this bug.