Bug 18077 - Integrate testapi.c into the Windows build
Summary: Integrate testapi.c into the Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-25 14:24 PDT by Adam Roben (:aroben)
Modified: 2008-03-25 16:26 PDT (History)
0 users

See Also:


Attachments
Step 1: Get testapi.c compiling under MSVC (5.62 KB, patch)
2008-03-25 15:30 PDT, Adam Roben (:aroben)
aroben: review+
Details | Formatted Diff | Diff
Step 2: Add testapi to the build (28.95 KB, patch)
2008-03-25 15:41 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Step 2 (updated): Add testapi to the build (13.15 KB, patch)
2008-03-25 15:47 PDT, Adam Roben (:aroben)
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2008-03-25 14:24:29 PDT
On Windows we never build testapi.c. It would be good to start building this so that we can test the JSC API.
Comment 1 Adam Roben (:aroben) 2008-03-25 15:30:14 PDT
Created attachment 20046 [details]
Step 1: Get testapi.c compiling under MSVC
Comment 2 Adam Roben (:aroben) 2008-03-25 15:41:18 PDT
Created attachment 20050 [details]
Step 2: Add testapi to the build
Comment 3 Adam Roben (:aroben) 2008-03-25 15:47:58 PDT
Created attachment 20052 [details]
Step 2 (updated): Add testapi to the build

This patch ensures that our build order remains linear.
Comment 4 Adam Roben (:aroben) 2008-03-25 16:17:36 PDT
Comment on attachment 20046 [details]
Step 1: Get testapi.c compiling under MSVC

r=sfalken
Comment 5 Adam Roben (:aroben) 2008-03-25 16:17:44 PDT
Comment on attachment 20052 [details]
Step 2 (updated): Add testapi to the build

r=sfalken
Comment 6 Adam Roben (:aroben) 2008-03-25 16:26:06 PDT
Committed in r31296 and r31297.