Bug 18060 - Assertion failure (JSLock not held) beneath JSCallbackObject<Base>::toString
Summary: Assertion failure (JSLock not held) beneath JSCallbackObject<Base>::toString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-25 00:00 PDT by Adam Roben (:aroben)
Modified: 2008-03-26 20:37 PDT (History)
1 user (show)

See Also:


Attachments
path without changelog or test (971 bytes, patch)
2008-03-25 00:00 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Patch + ChangeLog + test (4.17 KB, patch)
2008-03-25 18:49 PDT, Adam Roben (:aroben)
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2008-03-25 00:00:35 PDT
If you have a JSObjectRef that has a JSConvertToTypeCallback in its class, JSCallbackObject<Base>::toString will call JSValue::getString with a JSLock::DropAllLocks in scope, causing an assertion failure. I've got a fix for this, but need to add a testcase to testapi.c.
Comment 1 Adam Roben (:aroben) 2008-03-25 00:00:59 PDT
Created attachment 20023 [details]
path without changelog or test

Not for review yet
Comment 2 Adam Roben (:aroben) 2008-03-25 18:49:50 PDT
Created attachment 20073 [details]
Patch + ChangeLog + test
Comment 3 Geoffrey Garen 2008-03-25 21:42:10 PDT
Comment on attachment 20073 [details]
Patch + ChangeLog + test

r=me
Comment 4 Adam Roben (:aroben) 2008-03-26 20:37:01 PDT
Committed in r31350.