Bug 18059 - squirrelfish needs to compile on platforms without computed goto
Summary: squirrelfish needs to compile on platforms without computed goto
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-24 21:40 PDT by Oliver Hunt
Modified: 2008-03-24 22:08 PDT (History)
2 users (show)

See Also:


Attachments
First run at the patch (11.08 KB, patch)
2008-03-24 21:45 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2008-03-24 21:40:03 PDT
Tracking bug
Comment 1 Oliver Hunt 2008-03-24 21:45:35 PDT
Created attachment 20021 [details]
First run at the patch

Formatting of the runloop should be indented one level, but that will screw anyone with unlanded changes.  Also not entirely sure about having the computed goto conditionalised on the compiler support computed goto -- may be better to have an explicit (independent) flag later.
Comment 2 Geoffrey Garen 2008-03-24 21:59:05 PDT
+                ASSERT(isOpcode(opcode)); return m_opcodeIDTable.get(opcode);

Please move this onto two lines.
Comment 3 Oliver Hunt 2008-03-24 22:08:00 PDT
Landed r31276