Bug 18046 – SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Maciej Stachowiak]

SVGTextElement.getStartPositionOfChar counts the advance of each character in multichar glyphs individually. Instead, it should apply the advance of the whole glyph only after the last char of the multichar glyph, because SVG requires that characters all rendered as a unit are considered to have the same start position. This causes many problems on Acid3 test 79.

[Maciej Stachowiak]

Created attachment 20013 [details]
handle multichar glyph metrics and rendering correctly

[Eric Seidel (no email)]

Comment on attachment 20013 [details]
handle multichar glyph metrics and rendering correctly

Looks like you added a space before svgTextRunForInlineTextBox by accident. 

 LayoutTests/platform/mac/svg/text/multichar-glyph-expected.txt  is displaying an XML error (when it really probably should dump as text, no?)

It's possible to write SVG tests which use the shouldBe() stuff, and are js files, but it's not possible to have a custom SVG template.  Your copy/paste of shouldBe is less than ideal, but also OK.

[Eric Seidel (no email)]

Comment on attachment 20013 [details]
handle multichar glyph metrics and rendering correctly

Aside from my two corrections above, the patch looks sane.  extraCharsAvailable could be part of TextRun, but you had performance concerns.  I think it's OK to not have it part of TextRun (at least for now).

[Maciej Stachowiak]

Thanks. I fixed the two issues above before landing.