Bug 18010 – WebKitNetworkRequestPrivate is defined in two places unnecessarily

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jasper Bryant-Greene]

WebKitNetworkRequestPrivate is defined in both WebKit/gtk/webkit/webkitnetworkrequest.cpp and in WebKit/gtk/webkit/webkitprivate.h.

This is unnecessary code duplication as far as I can tell. Alternatively, if there is a reason for it then maybe some comments should be added?

Patch momentarily.

[Jasper Bryant-Greene]

Created attachment 19963 [details]
remove duplicate definition of WebKitNetworkRequest

[Jan Alonzo]

hi Jasper

I think you should move the struct and the _GET_PRIVATE macro out of webkitprivate.h and into webkitnetworkrequest.cpp. I think the frame and view structs just there because they need each other. 

Regards

[Jasper Bryant-Greene]

Hmm, you're right. I'm not sure what WebKitNetworkRequestPrivate is doing in webkitprivate.h at all, then. I initially assumed there must be a reason but a grep would indicate not. I'll move it into webkitnetworkrequest.cpp and build-test, and if that's OK, I'll submit a patch shortly.

[Jasper Bryant-Greene]

Created attachment 19969 [details]
updated patch removes dupe definition from webkitprivate.h rather than from webkitnetworkrequest.cpp

[Darin Adler]

Comment on attachment 19969 [details]
updated patch removes dupe definition from webkitprivate.h rather than from webkitnetworkrequest.cpp

r=me

[Julien Chaffraix]

Committed in r31480.