RESOLVED INVALID 17990
Repeated check in XMLHttpRequest::setRequestHeader 
https://bugs.webkit.org/show_bug.cgi?id=17990
Summary Repeated check in XMLHttpRequest::setRequestHeader
carlos pizano
Reported 2008-03-21 14:10:56 PDT
In XMLHttpRequest::setRequestHeader (cpp file) It appears that !isValidToken(name) || !isValidHeaderValue(value) Are performing the same test twice for '\n\r'. In other words isValidToken() is enough until somebody fixes the FIXME in line 131. Not a big deal.
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2008-03-24 00:36:35 PDT
I'm not sure if I understand this bug - isValidToken and isValidHeaderValue check different variables, how can they be redundant?
carlos pizano
Comment 2 2008-03-24 09:40:27 PDT
(In reply to comment #1) > I'm not sure if I understand this bug - isValidToken and isValidHeaderValue > check different variables, how can they be redundant? > You are right. I must need more coffee. Marking as invalid.
Note You need to log in before you can comment on or make changes to this bug.