Bug 17981 - CPPFLAGS are not configured properly in autotools build
Summary: CPPFLAGS are not configured properly in autotools build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-21 06:51 PDT by Rodney Dawes
Modified: 2008-03-21 11:24 PDT (History)
0 users

See Also:


Attachments
Patch to fix cppflags usage in autotools build (4.40 KB, patch)
2008-03-21 06:52 PDT, Rodney Dawes
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rodney Dawes 2008-03-21 06:51:41 PDT
Currently the CPPFLAGS configuration for the autotools build causes the JavaScriptCore includes to come before the WebCore includes. When building WebCore, it should find WebCore/config.h before others, which is not currently the case. The attached patch removes the JSCore include path options from global_cppflags, and places them in javascriptcore_cppflags instead, updating the other cppflags variables to use javascriptcore_cppflags when needed.
Comment 1 Rodney Dawes 2008-03-21 06:52:11 PDT
Created attachment 19924 [details]
Patch to fix cppflags usage in autotools build
Comment 2 Holger Freyther 2008-03-21 11:08:08 PDT
Comment on attachment 19924 [details]
Patch to fix cppflags usage in autotools build

The addition of WebCore cppflags to the programs in WebKitTools is wrong and should be removed when landing this patch.
Comment 3 Holger Freyther 2008-03-21 11:24:06 PDT
Landed in r31214.