Bug 17974 - REGRESSION: npfunctions.h should not import npruntime_internal.h
Summary: REGRESSION: npfunctions.h should not import npruntime_internal.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Nobody
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2008-03-20 17:20 PDT by Mark Rowe (bdash)
Modified: 2008-03-22 15:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch to rearrange includes (2.81 KB, patch)
2008-03-21 06:37 PDT, Rodney Dawes 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2008-03-20 17:20:28 PDT 
npfunctions.h is a public header file on the Mac, so it must not import npruntime_internal.h.
Comment 1 Mark Rowe (bdash) 2008-03-20 17:21:07 PDT 
<rdar://problem/5782310>
Comment 2 Mark Rowe (bdash) 2008-03-20 17:21:31 PDT 
Rodney, your change introduced this include.  Are you able to restructure things so that this import is not required?
Comment 3 Rodney Dawes 2008-03-21 06:37:53 PDT 
Created attachment 19923 [details]
Patch to rearrange includes
Comment 4 Mark Rowe (bdash) 2008-03-21 22:17:50 PDT 
Comment on attachment 19923 [details]
Patch to rearrange includes

r=me
Comment 5 Mark Rowe (bdash) 2008-03-22 15:03:12 PDT 
Landed in r31234.