Bug 17898 – Split PluginMessageThrottlerWin into its own files

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Rodney Dawes]

As a requirement for refactoring PluginView into shared code, we need to split out PluginMessageThrottlerWin into its own source files, so that the class is defined in a header which can be included, to resolve the methods needed by the OwnPtr template used with this class in PluginView. The attached patch accomplishes this.

[Rodney Dawes]

Created attachment 19844 [details]
Patch to split PluginMessageThrottlerWin from PluginViewWin.cpp

[Adam Roben (:aroben)]

Comment on attachment 19844 [details]
Patch to split PluginMessageThrottlerWin from PluginViewWin.cpp

+++ WebCore/plugins/PluginView.h	(working copy)
@@ -34,6 +34,7 @@
 #include "IntRect.h"
 #include "KURL.h"
 #include "PlatformString.h"
+#include "PluginMessageThrottlerWin.h"
 #include "PluginStream.h"
 #include "ResourceRequest.h"
 #include "Timer.h"
@@ -59,7 +60,6 @@ namespace WebCore {
     class KeyboardEvent;
     class MouseEvent;
     class KURL;
-    class PluginMessageThrottlerWin;
     class PluginPackage;
     class PluginRequest;
     class PluginStream;

This change should not be necessary for just moving the class into its own files.

PluginView.h should not change in this patch.

+#ifndef PluginMessageThrottlerWin_H

That should be a lowercase "h" at the end of the macro.

I'll fix the above two issues when landing this patch.

[Rodney Dawes]

(In reply to comment #2)
> This change should not be necessary for just moving the class into its own
> files.
> 
> PluginView.h should not change in this patch.

I changed this because the compile failed without doing so. I also noted this change in the ChangeLog entry.

[Adam Roben (:aroben)]

Committed in r31106

[Adam Roben (:aroben)]

(In reply to comment #3)
> (In reply to comment #2)
> > This change should not be necessary for just moving the class into its own
> > files.
> > 
> > PluginView.h should not change in this patch.
> 
> I changed this because the compile failed without doing so. I also noted this
> change in the ChangeLog entry.

It works just fine if you add the include to PluginViewWin.cpp instead, which is where it's actually needed. I did this before landing.