Bug 17845 - [GTK] combo box menu displayed in the wrong position
Summary: [GTK] combo box menu displayed in the wrong position
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P3 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-14 05:59 PDT by Marco Barisione
Modified: 2008-03-24 10:18 PDT (History)
2 users (show)

See Also:


Attachments
Show the popup in the right position and using the "push in" style to look like a normal combo box popup (2.57 KB, patch)
2008-03-14 08:18 PDT, Marco Barisione
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Barisione 2008-03-14 05:59:06 PDT
The popup menu used for combo boxes is displayed under the widget, but it should be displayed with the active item over it.
Comment 1 Marco Barisione 2008-03-14 08:18:15 PDT
Created attachment 19761 [details]
Show the popup in the right position and using the "push in" style to look like a normal combo box popup
Comment 2 Alp Toker 2008-03-24 09:45:31 PDT
So, I tried this patch.

Good idea, but the behaviour is a bit off in some cases. Trying the first few menu lists at:

http://www.google.pt/advanced_search?hl=pt-PT

.. half the menu is unpainted (ie. gray with no decorations)

If you can't reproduce this issue, let me know and I'll describe the symptoms in more detail.

I'm curious, are you using the same technique used within GTK+ internally to achieve this effect?
Comment 3 Pierre-Luc Beaudoin 2008-03-24 10:01:37 PDT
Alp, 

Very funny: I did the same test on that patch!  It happens that Gtk+ behaves that way: it leaves half the menu unpainted if the first element is selected when drawing the menu.

I based my Gtk+ observations on the gnome-language-selector using a faily small (800x600) resolution.  Try for yourself :)

In my opinion, this patch is behaving correctly.
Comment 4 Alp Toker 2008-03-24 10:16:59 PDT
Comment on attachment 19761 [details]
Show the popup in the right position and using the "push in" style to look like a normal combo box popup

Thanks for checking that Pierre-Luc.

r=me
Comment 5 Alp Toker 2008-03-24 10:18:15 PDT
Landed in r31244.