Bug 17810 - FloatConverison.h uses CG types (when using CG), possibly without CG header
Summary: FloatConverison.h uses CG types (when using CG), possibly without CG header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-12 14:38 PDT by Mark Mentovai
Modified: 2008-03-13 20:45 PDT (History)
0 users

See Also:

Attachments
#include CGBase.h to get CoreGraphics type definitions (828 bytes, patch)
2008-03-12 14:40 PDT, Mark Mentovai 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Mentovai 2008-03-12 14:38:14 PDT 
During a non-injected header build, FloatConversion.h can reference CoreGraphics types (when PLATFORM(CG) is true) without including any CoreGraphics headers.
Comment 1 Mark Mentovai 2008-03-12 14:40:12 PDT 
Created attachment 19715 [details]
#include CGBase.h to get CoreGraphics type definitions
Comment 2 Darin Adler 2008-03-13 10:09:45 PDT 
Comment on attachment 19715 [details]
#include CGBase.h to get CoreGraphics type definitions

Looks fine, r=me
Comment 3 Eric Seidel (no email) 2008-03-13 20:45:45 PDT 
Thank you mark for making such easy-to-land patches.  These took only a few minutes to land on my train ride home. :)

These are revisions r31048 through r31053