Bug 17805 - Can't build FastMalloc.cpp in certain non-pch non-AllInOneFile configurations
Summary: Can't build FastMalloc.cpp in certain non-pch non-AllInOneFile configurations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 17493
  Show dependency tree / graph
 
Reported: 2008-03-12 13:54 PDT by Mark Mentovai
Modified: 2008-03-13 20:45 PDT (History)
0 users

See Also:

Attachments
Move #include (991 bytes, patch)
2008-03-12 13:57 PDT, Mark Mentovai 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Mentovai 2008-03-12 13:54:52 PDT 
FastMalloc.cpp has an #include that can, in certain configurations, occur within "namespace WTF".  This is incorrect.  The #include should be moved so that it never occurs within an unexpected scope.
Comment 1 Mark Mentovai 2008-03-12 13:57:07 PDT 
Created attachment 19709 [details]
Move #include

The existing #include occurs within #if defined(WTF_CHANGES) && PLATFORM(DARWIN).  I selected the new location to also occur within preprocessor source that's active in the same case.
Comment 2 Eric Seidel (no email) 2008-03-12 14:22:41 PDT 
Comment on attachment 19709 [details]
Move #include

Yup.  Include was clearly wrong.  This looks fine.  Again, very surprised this would be failing in your compile environment and not ours.  r=me.
Comment 3 Eric Seidel (no email) 2008-03-13 20:45:45 PDT 
Thank you mark for making such easy-to-land patches.  These took only a few minutes to land on my train ride home. :)

These are revisions r31048 through r31053