RESOLVED FIXED 17797
WinLauncher Fails to Build on Build Bot 
https://bugs.webkit.org/show_bug.cgi?id=17797
Summary WinLauncher Fails to Build on Build Bot
Brent Fulgham
Reported 2008-03-12 10:38:21 PDT
Although WinLauncher builds correctly if the build is controlled through the Visual Studio IDE, it fails to build via the "build-webkit" script. This is because certain core windows libraries are not included in the link commands for the WinLauncher target.
Attachments
Use explicit library callouts (2.56 KB, patch)
2008-03-12 10:44 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Revised to just correct vsprops (1.32 KB, patch)
2008-03-12 12:33 PDT, Brent Fulgham 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2008-03-12 10:44:22 PDT
Created attachment 19702 [details] Use explicit library callouts * Correct include path for Release vsprops to use project variables (to be consistent with all other project files). * Correct Release and Debug builds to explicitly call out the required Windows libraries needed to produce a working executable.
Brent Fulgham
Comment 2 2008-03-12 12:33:17 PDT
Created attachment 19704 [details] Revised to just correct vsprops * Revised patch now that sfalken has added the library includes needed to build in r31000.
Darin Adler
Comment 3 2008-03-13 10:19:56 PDT
Comment on attachment 19704 [details] Revised to just correct vsprops Looks fine, even to someone with my admittedly-small level of Windows expertise. r=me
Matt Lilek
Comment 4 2008-03-13 21:40:07 PDT
Committed revision 31053.
Note You need to log in before you can comment on or make changes to this bug.