Bug 17788 - CookieJarWin must be split
Summary: CookieJarWin must be split
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-11 16:50 PDT by Brent Fulgham
Modified: 2008-03-11 17:34 PDT (History)
0 users

See Also:

Attachments
Split the cookies (15.67 KB, patch)
2008-03-11 17:09 PDT, Brent Fulgham 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2008-03-11 16:50:28 PDT 
In a land where #if/#endif macros are frowned upon, the CookieJarWin.cpp must surely be purged from our archive as EVERY SINGLE METHOD is conditionalized.
Comment 1 Brent Fulgham 2008-03-11 17:09:18 PDT 
Created attachment 19688 [details]
Split the cookies

Split the cookie jar into:
* CookieJarCFNetWin.cpp:  CFNetwork-specific cookie handling.
* CookieJarWin.cpp:  INet-ish cookie handling.
Comment 2 Adam Roben (:aroben) 2008-03-11 17:12:41 PDT 
Comment on attachment 19688 [details]
Split the cookies

r=me!
Comment 3 Matt Lilek 2008-03-11 17:34:51 PDT 
Landed in r30974.