Bug 17769 – WebKit compilation fixes for HP/UX acc

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Simon Hausmann]

The three attached patches make the Qt port of WebKit compile on HP/UX using aCC 6.

[Simon Hausmann]

Created attachment 19665 [details]
Change forward declarations used with RefPtr

[Simon Hausmann]

Created attachment 19666 [details]
Fix for scoping with broken compilers

[Simon Hausmann]

Created attachment 19667 [details]
Avoid the use of typename with aCC 6

[Darin Adler]

Comment on attachment 19665 [details]
Change forward declarations used with RefPtr

r=me

[Darin Adler]

We're going to need a buildbot using HP/UX, or this will keep regressing over and over again.

[Darin Adler]

Comment on attachment 19667 [details]
Avoid the use of typename with aCC 6

This is not correctly using include files. Definitions like this should not be in Platform.h.

What *should* go in Platform.h is a definition to let us use COMPILER() to identify the HP compiler.

The actual macro can either go in ListHashSet.h or a new header, but should not go in Platform.h.

Have you checked to see if you can leave typename out with the other compilers? Maybe this doesn't require a macro at all?

If it does require a macro, then I don't think WTF_TYPENAME is descriptive enough. It makes it sound like you have to use this everywhere, when really it's only for a few specific call sites. The name will probably need to mention HP specifically.

[Darin Adler]

Comment on attachment 19666 [details]
Fix for scoping with broken compilers

This workaround does not belong in Platform.h. That file only defines macros to identify the platform, not workarounds for bugs or anything like that. It should not be commandeered for this new purpose.

+#if (defined(_MSC_VER) && _MSC_VER-0 < 1300 && !defined(__INTEL_COMPILER)) || defined(__sgi) || (defined(__HP_aCC) && defined(__ia64))

This is not how we do things with the Platform.h file. You should be using the COMPILER() macros defined in there and adding new ones as needed.

This should go in a new header file. There may be some clever way of including it in all the projects, but adding it to Platform.h is not right.

[Darin Adler]

Comment on attachment 19665 [details]
Change forward declarations used with RefPtr

Committed revision 31082.

[Darin Adler]

Comment on attachment 19665 [details]
Change forward declarations used with RefPtr

Cleared review flag since this was landed so it doesn't show up in the uncommitted queue.

[Alexey Proskuryakov]

Marking as fixed, because something was landed here. Please open new bugs for other patches if they are still needed.