RESOLVED FIXED 17683
Standardize on #if USE(SAFARI_THEME) 
https://bugs.webkit.org/show_bug.cgi?id=17683
Summary Standardize on #if USE(SAFARI_THEME)
Brent Fulgham
Reported 2008-03-05 11:16:44 PST
Now that the SAFARI_THEME state is controlled by the wtf/Platform.h file, we should use this in preference to the manually defined macros in the various project files. This patch only modifies the source files. It does not modify the project files. For this, see http://bugs.webkit.org/show_bug.cgi?id=17675.
Attachments
Update to properly conditionalize SAFARI_THEME (3.77 KB, patch)
2008-03-05 11:46 PST, Brent Fulgham 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2008-03-05 11:46:04 PST
Created attachment 19551 [details] Update to properly conditionalize SAFARI_THEME Patch: * moves WTF_USE_SAFARI_THEME to a place where it actually gets defined * Modifies source files to use "#if USE(SAFARI_THEME)", rather than the USE_SAFARI_THEME currently hard-coded in project files.
Brent Fulgham
Comment 2 2008-03-05 11:47:48 PST
I discovered while working on http://bugs.webkit.org/show_bug.cgi?id=17675 that the new USE(SAFARI_THEME) macro was not getting defined, and builds were only successful because "USE_SAFARI_THEME" is defined in the Visual Studio project file. This patch corrects the definition so that 17675 will work properly.
Adam Roben (:aroben)
Comment 3 2008-03-05 11:49:57 PST
Comment on attachment 19551 [details] Update to properly conditionalize SAFARI_THEME r=me
Mark Rowe (bdash)
Comment 4 2008-03-05 14:45:16 PST
Landed in r30812.
Note You need to log in before you can comment on or make changes to this bug.