Bug 17579 - simultaneouslyRegsiteredTimerFireOrder.html is spelled wrong and uses bad line endings
Summary: simultaneouslyRegsiteredTimerFireOrder.html is spelled wrong and uses bad lin...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-27 16:25 PST by Eric Seidel (no email)
Modified: 2008-02-27 20:01 PST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-02-27 16:25:36 PST
simultaneouslyRegsiteredTimerFireOrder.html is spelled wrong and uses bad line endings

The name has a typo in it.

Also, the code uses     document.getElementById("pre").appendChild(document.createTextNode(s + "\r\n"));

which just seems evil and wrong.

That should be changed to use <br>s or "\n" or better yet, to use the logging functions from the js-tests-pre.js file found in fast/js/resources.js
Comment 1 Eric Seidel (no email) 2008-02-27 18:42:27 PST
There seem to be a couple other examples of this strange use of \r\n:

fast/dom/set-inner-text-newlines.html:        div.innerText = "\r\nText\r\nwith\r\nnewlines\r\n\r\n";
fast/dom/simultaneouslyRegsiteredTimerFireOrder.html:    document.getElementById("pre").appendChild(document.createTextNode(s + "\r\n"));
fast/dom/Window/btoa-pnglet.html:  return "\211PNG\r\n\032\n"+this.png.join('');
fast/dom/Window/window-property-clearing.html:    document.getElementById("console").appendChild(document.createTextNode(s + "\r\n"));
fast/dom/Window/window-property-clearing.html:    log("\r\nPage " + count + ":");

Comment 2 Eric Seidel (no email) 2008-02-27 20:01:00 PST
When i tried to add svn:eol-style from my windows box, it claimed these -expected.txt files had inconsistent line endings.  Instead I added the property from my os x box.  I expect the next time anyone tries to modify one of these test cases from windows svn will barf at them.