Bug 17579 – simultaneouslyRegsiteredTimerFireOrder.html is spelled wrong and uses bad line endings

• Status: NEW
• Component: New Bugs

[Eric Seidel (no email)]

simultaneouslyRegsiteredTimerFireOrder.html is spelled wrong and uses bad line endings

The name has a typo in it.

Also, the code uses     document.getElementById("pre").appendChild(document.createTextNode(s + "\r\n"));

which just seems evil and wrong.

That should be changed to use <br>s or "\n" or better yet, to use the logging functions from the js-tests-pre.js file found in fast/js/resources.js

[Eric Seidel (no email)]

There seem to be a couple other examples of this strange use of \r\n:

fast/dom/set-inner-text-newlines.html:        div.innerText = "\r\nText\r\nwith\r\nnewlines\r\n\r\n";
fast/dom/simultaneouslyRegsiteredTimerFireOrder.html:    document.getElementById("pre").appendChild(document.createTextNode(s + "\r\n"));
fast/dom/Window/btoa-pnglet.html:  return "\211PNG\r\n\032\n"+this.png.join('');
fast/dom/Window/window-property-clearing.html:    document.getElementById("console").appendChild(document.createTextNode(s + "\r\n"));
fast/dom/Window/window-property-clearing.html:    log("\r\nPage " + count + ":");

[Eric Seidel (no email)]

When i tried to add svn:eol-style from my windows box, it claimed these -expected.txt files had inconsistent line endings.  Instead I added the property from my os x box.  I expect the next time anyone tries to modify one of these test cases from windows svn will barf at them.

[Ahmad Saleem]

Renamed - https://github.com/WebKit/WebKit/commit/8a0764b139746a0a2a7a9cdd9ee1edb8709cee71

Plus this got changed:

https://searchfox.org/wubkat/rev/c1fefa0bb16a18b82461ac3111b56f3395e7a1b7/LayoutTests/fast/dom/simultaneously-registered-timer-fire-order.html#11

by https://commits.webkit.org/113186@main

___

> fast/dom/set-inner-text-newlines.html:        div.innerText = "\r\nText\r\nwith\r\nnewlines\r\n\r\n";

Still same and also in Blink.

[set-inner-text-newlines.html](https://searchfox.org/wubkat/rev/c1fefa0bb16a18b82461ac3111b56f3395e7a1b7/LayoutTests/fast/dom/set-inner-text-newlines.html#20)


> fast/dom/Window/btoa-pnglet.html:  return "\211PNG\r\n\032\n"+this.png.join('');

Still same and also in Blink.

[btoa-pnglet.html](https://searchfox.org/wubkat/rev/c1fefa0bb16a18b82461ac3111b56f3395e7a1b7/LayoutTests/fast/dom/Window/btoa-pnglet.html#766)

> fast/dom/Window/window-property-clearing.html:

same commit fixed > https://commits.webkit.org/113186@main

____

@Alexey - any idea, if we need to do anything here.