Two problems are encountered when trying to build CollectorHeapIntrospector.cpp, a Mac-only file, as a standalone, as opposed to building it normally, which involves including it from AllInOneFile.cpp: There's a forward-declaration problems: CollectorHeap needs to be visible to CollectorHeapIntrospector, but it's not visible from collector.h like it should be. Instead, CollectorHeap is declared solely in collector.cc. A forward declaration is present in CollectorHeapIntrospector.h, which is sufficient to use CollectorHeap as a pointer type, but CollectorHeapIntrospector.cpp dereferences CollectorHeaps. This isn't a problem in the AllInOneFile build because collector.cc, where the struct is currently defined, is included before CollectorHeapIntrospector. The solution is to move the definition of CollectorHeap into collector.h. There's also a namespace problem: CollectorHeapIntrospector needs to access something WTF::RemoteMemoryReader, but it does so by calling it RemoteMemoryReader without being in the WTF namespace or providing an appropriate "using" declaration or directive. Some other source file must have a "using namespace WTF;" that masks the problem in the AllInOneFile build. When building CollectorHeapIntrospector.cpp as a standalone, RemoteMemoryReader can't be found. The solution is to fully-qualify RemoteMemoryReader or use a using-declaration or directive.
Created attachment 19355 [details] Move the definition of CollectorHeap into collector.h, and provide a "using" declaration for WTF::RemoteMemoryReader
Comment on attachment 19355 [details] Move the definition of CollectorHeap into collector.h, and provide a "using" declaration for WTF::RemoteMemoryReader The patch looks good to me, but it will need a ChangeLog before it can be landed. Please see the instructions at <http://webkit.org/coding/contributing.html> and attach an updated patch with a ChangeLog entry for JavaScriptCore.
Created attachment 19356 [details] v2, includes ChangeLog entry Whoops, sorry about that.
Comment on attachment 19356 [details] v2, includes ChangeLog entry r=me.
Landed in r30576. Thanks for the patch!