Bug 17505 - Add support for getting command line arguments in testkjs
Summary: Add support for getting command line arguments in testkjs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-23 22:14 PST by Sam Weinig
Modified: 2008-02-24 17:46 PST (History)
1 user (show)

See Also:


Attachments
work in progress (3.07 KB, patch)
2008-02-23 22:23 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
patch (4.18 KB, patch)
2008-02-24 14:59 PST, Sam Weinig
oliver: review+
Details | Formatted Diff | Diff
updated patch (4.59 KB, patch)
2008-02-24 17:24 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
updated without build issues (4.58 KB, patch)
2008-02-24 17:25 PST, Sam Weinig
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2008-02-23 22:14:30 PST
The SpiderMonkey js shell supports passing command line arguments to the scripts being executed by way of a global 'arguments' variable.
Comment 1 Sam Weinig 2008-02-23 22:23:09 PST
Created attachment 19310 [details]
work in progress
Comment 2 Sam Weinig 2008-02-24 14:59:58 PST
Created attachment 19328 [details]
patch
Comment 3 Brent Fulgham 2008-02-24 16:18:23 PST
This definitely works well, and allowed generation of performance data for http://shootout.alioth.debian.org
Comment 4 Oliver Hunt 2008-02-24 16:46:56 PST
Comment on attachment 19328 [details]
patch

r=me, provided you ensure run-javscriptcore-tests and run-sunspider still work correctly
Comment 5 Sam Weinig 2008-02-24 17:24:09 PST
Created attachment 19330 [details]
updated patch
Comment 6 Sam Weinig 2008-02-24 17:25:56 PST
Created attachment 19331 [details]
updated without build issues
Comment 7 Mark Rowe (bdash) 2008-02-24 17:37:34 PST
Comment on attachment 19331 [details]
updated without build issues

r=me
Comment 8 Sam Weinig 2008-02-24 17:37:54 PST
Landed in r30553.