Bug 17504 - Speed up DOM lists array subscription syntax by using the fast getOwnPropertySlot and set paths
Summary: Speed up DOM lists array subscription syntax by using the fast getOwnProperty...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-23 17:20 PST by Sam Weinig
Modified: 2008-02-23 17:37 PST (History)
2 users (show)

See Also:

Attachments
patch (5.67 KB, patch)
2008-02-23 17:32 PST, Sam Weinig 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2008-02-23 17:20:36 PST 
We are needlessly converting from unsigned -> Identifier -> unsigned when doing indexGetting and setting for DOM lists like the NodeList or the new CanvasPixelArray.  We can speed it up by using the fast getOwnPropertySlot and put methods that take an unsigned.  This technique is already employed by ArrayInstance.
Comment 1 Sam Weinig 2008-02-23 17:32:20 PST 
Created attachment 19308 [details]
patch

This speeds Oliver's CanvasPixelArray test up by 6x.
Comment 2 Sam Weinig 2008-02-23 17:37:05 PST 
Landed in r30529.