On Windows, WebFrame implements FrameLoaderClient. This bloats the WebFrame class, and doesn't match all the other platforms, which all have a separate class that implements FrameLoaderClient. We should switch Windows to match the other platforms.
Created attachment 19304 [details] Move two more methods More methods will come, but I'd like to get them reviewed and landed in small chunks.
Created attachment 19306 [details] Move many dispatch methods
Created attachment 19357 [details] remove an unused method
Comment on attachment 19304 [details] Move two more methods Clearing review flag since this has been landed.
Comment on attachment 19306 [details] Move many dispatch methods Clearing review flag since this has been landed.
Comment on attachment 19357 [details] remove an unused method r=me
Created attachment 19358 [details] Move progress-related methods
Comment on attachment 19358 [details] Move progress-related methods r=me
Created attachment 19360 [details] Move createFrame
Comment on attachment 19360 [details] Move createFrame r=me
Created attachment 19361 [details] Move plugin-related methods
Comment on attachment 19361 [details] Move plugin-related methods r=me
Comment on attachment 19357 [details] remove an unused method Landed as r30579
Comment on attachment 19358 [details] Move progress-related methods Landed as r30580
Comment on attachment 19360 [details] Move createFrame Landed as r30581
Comment on attachment 19361 [details] Move plugin-related methods Landed as r30582
Created attachment 19376 [details] Move cache-related methods
Created attachment 19377 [details] Move WebHistory-related methods
Created attachment 19378 [details] Get rid of IID_WebFrame
Created attachment 19379 [details] Move two more methods
Created attachment 19380 [details] Move ResourceLoadDelegate methods
Comment on attachment 19376 [details] Move cache-related methods r=me
Comment on attachment 19377 [details] Move WebHistory-related methods r=me
Comment on attachment 19378 [details] Get rid of IID_WebFrame r=me
Comment on attachment 19379 [details] Move two more methods r=me
Comment on attachment 19380 [details] Move ResourceLoadDelegate methods r=me
Comment on attachment 19376 [details] Move cache-related methods Landed as r30608
Comment on attachment 19377 [details] Move WebHistory-related methods Landed as r30609
Comment on attachment 19378 [details] Get rid of IID_WebFrame Landed as r30610
Comment on attachment 19379 [details] Move two more methods Landed as r30611
Comment on attachment 19380 [details] Move ResourceLoadDelegate methods Landed as r30612
Created attachment 19389 [details] WIP patch to move PolicyDelegate-related methods Here's a patch that moves the PolicyDelegate-related methods to WebFrameLoaderClient. Everything looks fine, but for some reason when the ResourceRequest gets passed from FrameLoader::checkNavigationPolicy to WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction, the const ResourceRequest& parameter becomes garbage and we crash.
Adam, is this bug report still actionable?