Bug 17503 - WebFrame should not implement FrameLoaderClient
Summary: WebFrame should not implement FrameLoaderClient
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Minor
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-23 12:37 PST by Adam Roben (:aroben)
Modified: 2010-06-11 17:25 PDT (History)
2 users (show)

See Also:


Attachments
Move two more methods (3.88 KB, patch)
2008-02-23 12:38 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Move many dispatch methods (14.98 KB, patch)
2008-02-23 12:41 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
remove an unused method (1.97 KB, patch)
2008-02-25 15:08 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Move progress-related methods (6.92 KB, patch)
2008-02-25 15:16 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Move createFrame (13.97 KB, patch)
2008-02-25 15:37 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Move plugin-related methods (22.53 KB, patch)
2008-02-25 15:56 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Move cache-related methods (10.25 KB, patch)
2008-02-26 09:19 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Move WebHistory-related methods (9.73 KB, patch)
2008-02-26 09:19 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Get rid of IID_WebFrame (3.60 KB, patch)
2008-02-26 09:19 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Move two more methods (8.71 KB, patch)
2008-02-26 09:19 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Move ResourceLoadDelegate methods (18.24 KB, patch)
2008-02-26 09:20 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
WIP patch to move PolicyDelegate-related methods (20.23 KB, patch)
2008-02-26 16:54 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2008-02-23 12:37:02 PST
On Windows, WebFrame implements FrameLoaderClient. This bloats the WebFrame class, and doesn't match all the other platforms, which all have a separate class that implements FrameLoaderClient. We should switch Windows to match the other platforms.
Comment 1 Adam Roben (:aroben) 2008-02-23 12:38:12 PST
Created attachment 19304 [details]
Move two more methods

More methods will come, but I'd like to get them reviewed and landed in small chunks.
Comment 2 Adam Roben (:aroben) 2008-02-23 12:41:46 PST
Created attachment 19306 [details]
Move many dispatch methods
Comment 3 Adam Roben (:aroben) 2008-02-25 15:08:13 PST
Created attachment 19357 [details]
remove an unused method
Comment 4 Adam Roben (:aroben) 2008-02-25 15:08:29 PST
Comment on attachment 19304 [details]
Move two more methods

Clearing review flag since this has been landed.
Comment 5 Adam Roben (:aroben) 2008-02-25 15:08:36 PST
Comment on attachment 19306 [details]
Move many dispatch methods

Clearing review flag since this has been landed.
Comment 6 Anders Carlsson 2008-02-25 15:13:18 PST
Comment on attachment 19357 [details]
remove an unused method

r=me
Comment 7 Adam Roben (:aroben) 2008-02-25 15:16:36 PST
Created attachment 19358 [details]
Move progress-related methods
Comment 8 Anders Carlsson 2008-02-25 15:23:04 PST
Comment on attachment 19358 [details]
Move progress-related methods

r=me
Comment 9 Adam Roben (:aroben) 2008-02-25 15:37:29 PST
Created attachment 19360 [details]
Move createFrame
Comment 10 Anders Carlsson 2008-02-25 15:42:04 PST
Comment on attachment 19360 [details]
Move createFrame

r=me
Comment 11 Adam Roben (:aroben) 2008-02-25 15:56:26 PST
Created attachment 19361 [details]
Move plugin-related methods
Comment 12 Anders Carlsson 2008-02-25 16:01:46 PST
Comment on attachment 19361 [details]
Move plugin-related methods

r=me
Comment 13 Adam Roben (:aroben) 2008-02-25 17:01:31 PST
Comment on attachment 19357 [details]
remove an unused method

Landed as r30579
Comment 14 Adam Roben (:aroben) 2008-02-25 17:04:50 PST
Comment on attachment 19358 [details]
Move progress-related methods

Landed as r30580
Comment 15 Adam Roben (:aroben) 2008-02-25 17:05:25 PST
Comment on attachment 19360 [details]
Move createFrame

Landed as r30581
Comment 16 Adam Roben (:aroben) 2008-02-25 17:05:50 PST
Comment on attachment 19361 [details]
Move plugin-related methods

Landed as r30582
Comment 17 Adam Roben (:aroben) 2008-02-26 09:19:15 PST
Created attachment 19376 [details]
Move cache-related methods
Comment 18 Adam Roben (:aroben) 2008-02-26 09:19:28 PST
Created attachment 19377 [details]
Move WebHistory-related methods
Comment 19 Adam Roben (:aroben) 2008-02-26 09:19:43 PST
Created attachment 19378 [details]
Get rid of IID_WebFrame
Comment 20 Adam Roben (:aroben) 2008-02-26 09:19:56 PST
Created attachment 19379 [details]
Move two more methods
Comment 21 Adam Roben (:aroben) 2008-02-26 09:20:12 PST
Created attachment 19380 [details]
Move ResourceLoadDelegate methods
Comment 22 Anders Carlsson 2008-02-26 09:47:54 PST
Comment on attachment 19376 [details]
Move cache-related methods

r=me
Comment 23 Anders Carlsson 2008-02-26 09:48:37 PST
Comment on attachment 19377 [details]
Move WebHistory-related methods

r=me
Comment 24 Anders Carlsson 2008-02-26 09:51:00 PST
Comment on attachment 19378 [details]
Get rid of IID_WebFrame

r=me
Comment 25 Anders Carlsson 2008-02-26 09:51:38 PST
Comment on attachment 19379 [details]
Move two more methods

r=me
Comment 26 Anders Carlsson 2008-02-26 09:52:14 PST
Comment on attachment 19380 [details]
Move ResourceLoadDelegate methods

r=me
Comment 27 Adam Roben (:aroben) 2008-02-26 16:49:20 PST
Comment on attachment 19376 [details]
Move cache-related methods

Landed as r30608
Comment 28 Adam Roben (:aroben) 2008-02-26 16:49:59 PST
Comment on attachment 19377 [details]
Move WebHistory-related methods

Landed as r30609
Comment 29 Adam Roben (:aroben) 2008-02-26 16:50:26 PST
Comment on attachment 19378 [details]
Get rid of IID_WebFrame

Landed as r30610
Comment 30 Adam Roben (:aroben) 2008-02-26 16:50:51 PST
Comment on attachment 19379 [details]
Move two more methods

Landed as r30611
Comment 31 Adam Roben (:aroben) 2008-02-26 16:51:21 PST
Comment on attachment 19380 [details]
Move ResourceLoadDelegate methods

Landed as r30612
Comment 32 Adam Roben (:aroben) 2008-02-26 16:54:50 PST
Created attachment 19389 [details]
WIP patch to move PolicyDelegate-related methods

Here's a patch that moves the PolicyDelegate-related methods to WebFrameLoaderClient. Everything looks fine, but for some reason when the ResourceRequest gets passed from FrameLoader::checkNavigationPolicy to WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction, the const ResourceRequest& parameter becomes garbage and we crash.
Comment 33 Alexey Proskuryakov 2010-06-11 17:25:52 PDT
Adam, is this bug report still actionable?