Bug 17499 – Display issue--extended calendar on delta.com

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Layout and Rendering

[Mark Cohen]

On delta.com in the award calendar path (https://www.delta.com/awards/home.do?EventId=ENTER_APPLICATION, submit cities to search on, calendar appears), the calendar display is extended. The header space above the calendar display is much longer than it should be.

[Mark Cohen]

Created attachment 19296 [details]
Image showing rendering in Safari vs. Firefox

[Matt Lilek]

Trying to reproduce this with my local build hit the following assertion failure:

ASSERTION FAILED: m_pendingStylesheets > 0
(/Users/matt/Code/WebKit/WebCore/dom/Document.cpp:2028 void WebCore::Document::removePendingSheet())

Thread 0 Crashed:
0   com.apple.WebCore             	0x01c6d73d WebCore::Document::removePendingSheet() + 73 (Document.cpp:2028)
1   com.apple.WebCore             	0x01d3104e WebCore::HTMLLinkElement::sheetLoaded() + 106 (HTMLLinkElement.cpp:247)
2   com.apple.WebCore             	0x01bb457f WebCore::CSSStyleSheet::checkLoaded() + 109 (CSSStyleSheet.cpp:179)
3   com.apple.WebCore             	0x01d321c2 WebCore::HTMLLinkElement::setCSSStyleSheet(WebCore::String const&, WebCore::String const&, WebCore::CachedCSSStyleSheet const*) + 402 (HTMLLinkElement.cpp:231)
4   com.apple.WebCore             	0x01bba0bd WebCore::CachedCSSStyleSheet::checkNotify() + 155 (CachedCSSStyleSheet.cpp:94)
5   com.apple.WebCore             	0x01bba508 WebCore::CachedCSSStyleSheet::data(WTF::PassRefPtr<WebCore::SharedBuffer>, bool) + 362 (CachedCSSStyleSheet.cpp:85)
6   com.apple.WebCore             	0x02127d8e WebCore::Loader::didFinishLoading(WebCore::SubresourceLoader*) + 308 (loader.cpp:113)
7   com.apple.WebCore             	0x020a16f3 WebCore::SubresourceLoader::didFinishLoading() + 169 (SubresourceLoader.cpp:195)
8   com.apple.WebCore             	0x01fa566e WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*) + 24 (ResourceLoader.cpp:373)
9   com.apple.WebCore             	0x01fa3049 -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] + 101 (ResourceHandleMac.mm:469)
10  com.apple.Foundation          	0x90dea8b7 -[NSURLConnection(NSURLConnectionReallyInternal) sendDidFinishLoading] + 87
11  com.apple.Foundation          	0x90dea844 _NSURLConnectionDidFinishLoading + 68
12  com.apple.CFNetwork           	0x92c507f3 sendDidFinishLoadingCallback + 148
13  com.apple.CFNetwork           	0x92c4d920 _CFURLConnectionSendCallbacks + 1994
14  com.apple.CFNetwork           	0x92c4d0d9 muxerSourcePerform + 283
15  com.apple.CoreFoundation      	0x943af62e CFRunLoopRunSpecific + 3166
16  com.apple.CoreFoundation      	0x943afd18 CFRunLoopRunInMode + 88
17  com.apple.HIToolbox           	0x910986a0 RunCurrentEventLoopInMode + 283
18  com.apple.HIToolbox           	0x910984b9 ReceiveNextEventCommon + 374
19  com.apple.HIToolbox           	0x9109832d BlockUntilNextEventMatchingListInMode + 106
20  com.apple.AppKit              	0x917047d9 _DPSNextEvent + 657
21  com.apple.AppKit              	0x9170408e -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128
22  com.apple.Safari              	0x0000965e 0x1000 + 34398
23  com.apple.AppKit              	0x916fd0c5 -[NSApplication run] + 795
24  com.apple.AppKit              	0x916ca30a NSApplicationMain + 574
25  com.apple.Safari              	0x00002a76 0x1000 + 6774

[Matt Lilek]

(In reply to comment #2)
> Trying to reproduce this with my local build hit the following assertion
> failure:
> 
> ASSERTION FAILED: m_pendingStylesheets > 0
> (/Users/matt/Code/WebKit/WebCore/dom/Document.cpp:2028 void
> WebCore::Document::removePendingSheet())
> 

This is actually the 2nd time I've hit this ASSERT in the last ~36 hours - the first time was on a site that can't be posted and my initial attempts at a quick reduction failed.

[Matt Lilek]

(In reply to comment #3)
> (In reply to comment #2)
> > Trying to reproduce this with my local build hit the following assertion
> > failure:
> > 
> > ASSERTION FAILED: m_pendingStylesheets > 0
> > (/Users/matt/Code/WebKit/WebCore/dom/Document.cpp:2028 void
> > WebCore::Document::removePendingSheet())
> > 
> 
> This is actually the 2nd time I've hit this ASSERT in the last ~36 hours - the
> first time was on a site that can't be posted and my initial attempts at a
> quick reduction failed.
> 

After talking to Mitz, this crash is unrelated to the rendering issue.

[Frances Cornwall]

I can't use web archive to see what was going wrong around 2007/2008, for example: https://web.archive.org/web/20080819032929/https://www.delta.com/awards/home.do?EventId=ENTER_APPLICATION

gives a response:
"Not Found

The requested object does not exist on this server. The link you followed is either outdated, inaccurate, or the server has been instructed not to let you have it."

and: https://web.archive.org/web/20070625162302/https://www.delta.com/awards/home.do?EventId=ENTER_APPLICATION

gives a response containing the "website had a hiccup"

The current calendar works at: https://www.delta.com/flight-search/book-a-flight?tripType=ROUND_TRIP&EventId=ENTER_APPLICATION.

We can probably close this bug if it is not an issue in rendering.

[Frances Cornwall]

Created attachment 471079 [details]
screenshot of web archive June 25, 2007

[Frances Cornwall]

Created attachment 471080 [details]
screenshot of calendar currently

[Frances Cornwall]

Created attachment 471081 [details]
screenshot of web archive August 17, 2008

[Frances Cornwall]

Created attachment 471082 [details]
screenshot of web archive March 16, 2008

[Karl Dubost]

yes without the initial markup failing, there is nothing which can be investigated.