Bug 17478 - testkjs build lacks some defines
Summary: testkjs build lacks some defines
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-21 11:32 PST by Mike Hommey
Modified: 2011-09-06 22:50 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Hommey 2008-02-21 11:32:01 PST 
When building from qmake generated Makefiles, and building the testkjs target in JavaScriptCore/kjs, a whole bunch of defines are lacking on the gcc command line, more specifically -DNDEBUG when not building debug builds, which, in turn, has the nice side effect of provoking a gcc internal compiler error on s390 because of the 0xbbadbeef pointer, which is another story. The following patch is enough to bring the defines in, though that might be too much

diff --git a/JavaScriptCore/kjs/testkjs.pro b/JavaScriptCore/kjs/testkjs.pro
index ab3016b..dcffabb 100644
--- a/JavaScriptCore/kjs/testkjs.pro
+++ b/JavaScriptCore/kjs/testkjs.pro
@@ -20,6 +20,7 @@ OBJECTS_DIR = tmp
 OBJECTS_DIR_WTR = $$OBJECTS_DIR/
 win32-*: OBJECTS_DIR_WTR ~= s|/|\|
 include($$PWD/../JavaScriptCore.pri)
+include($$PWD/../../WebKit.pri)
 
 # Hack!  Fix this.
 SOURCES -= API/JSBase.cpp \
Comment 1 Gavin Barraclough 2011-09-06 22:50:01 PDT 
Resolving because none of this still exists.  If this bug is in any way still valid (e.g. is testapi a descendant of testkjs) then please reopen with updated steps to reproduce. Thanks!