RESOLVED FIXED 17445
[GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed" 
https://bugs.webkit.org/show_bug.cgi?id=17445
Summary [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
Mike Auty
Reported 2008-02-20 03:16:44 PST
The GNUmakefile.am files make use of the LDFLAGS variable to include library additions such as -ljpeg etc. Unfortunately, if these inclusions aren't made in LIBADD/LDADD variables, then they are mis-ordered during the linking. The as-needed flag discards libraries whose functions have not been needed by earlier libraries, which therefore makes the ordering important. I'll be attaching a patch directly after this, built against a recent nightly build. This could potentially affect other build systems/OSes, but I've only been able to confirm that the patch fixes the build issues on linux.
Attachments
webkitgtk-30267-as-needed.patch (2.03 KB, patch)
2008-02-20 03:21 PST, Mike Auty 		alp: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Auty
Comment 1 2008-02-20 03:21:57 PST
Created attachment 19224 [details] webkitgtk-30267-as-needed.patch This moves all -l library inclusion statements from LDFLAGS variables to LIBADD/LDADD variables. It applies cleanly against r30267. If you require newer versions or any further information, please just ask. 5:)
Alp Toker
Comment 2 2008-02-21 11:43:55 PST
Comment on attachment 19224 [details] webkitgtk-30267-as-needed.patch r=me Sorry about the delay. I'll clean up a few whitespace mistakes in GNUmakefile.am and write a ChangeLog entry for you this time, but in future please look into doing these in your patches. Thanks
Alp Toker
Comment 3 2008-02-21 11:45:16 PST
Landed in r30459. I also took out an unneeded -ljpeg from the GtkLauncher flags.
Note You need to log in before you can comment on or make changes to this bug.