Bug 17390 – eliminate DeprecatedString

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Darin Adler]

Sam and I are getting close!

[Darin Adler]

Created attachment 19155 [details]
work in progress

[Sam Weinig]

Created attachment 19159 [details]
Move all uses of toInt (and friends) to String

This patch takes a chunk of the uses of DeprecatedString out.  I am not thrilled with the names, so any suggestions would be great.  I think in the future we can make the String API a little nicer by allowing both the forms of toInt (strict and non-strict, could use better names for that too) to take a base parameter, but since that wasn't necessary for this I left it out.

[Darin Adler]

Comment on attachment 19159 [details]
Move all uses of toInt (and friends) to String

I think that having functions to do arbitrary base is overkill, since we rarely need anything except base 10.

 803     CString latin1String = Latin1Encoding().encode(data, length);
 804     double val = kjs_strtod(latin1String.data(), &end);

I don't think the above is efficient enough. There's no reason this has to allocate memory. We should convert to narrow characters in a fixed-size stack buffer.

r=me

[Sam Weinig]

Darin,

Your change looks really good, but I think it would be cleaner to review and commit it in logical chucks.  There seem to be a couple of different removals that makes sense by themselves, the CSS changes (it might also be able to be split up, though I don't think that is necessary), the changes to TextStream, the removal of the dump() methods (we may want to take an informal poll to make sure those really aren't used by anyone, some times Hyatt surprises me with what tools in the code he uses), RegularExpression changes, DeprecatedStringList removal, etc.  Yeah!

[Darin Adler]

Comment on attachment 19159 [details]
Move all uses of toInt (and friends) to String

Clearing flag since Sam landed this.

[Darin Adler]

Created attachment 19189 [details]
work in progress

I don't intend to land all these changes at once. Some of these are not even required to remove DeprecatedString. But it's a good set of changes in pretty good shape right now.

[Darin Adler]

Created attachment 19203 [details]
work in progress

[Darin Adler]

Created attachment 19204 [details]
work in progress

[Darin Adler]

Created attachment 19246 [details]
work in progress

[Darin Adler]

Sam fixed this in r30501