RESOLVED FIXED 17383
g_object_unref() critical errors on console 
https://bugs.webkit.org/show_bug.cgi?id=17383
Summary g_object_unref() critical errors on console
Alp Toker
Reported 2008-02-15 16:51:01 PST
This is a refcounting issue introduced in r30226 or one of the preceding/following revisions. In certain applications (eg. DevHelp), WebView content is no longer visible and the page is always empty. There are some potential circular refcounting issues here that may need to be looked at too, but the priority should be to get things working and worry about plugging the leaks later.
Attachments
Add attachment proposed patch, testcase, etc.
Alp Toker
Comment 1 2008-02-15 16:51:34 PST
The unref messages appear when leaving eg. http://maps.google.com/
Holger Freyther
Comment 2 2008-02-15 17:13:45 PST
Let us: a) revert the refcount changes b) settle for the traditional scheme that FrameLoaderClient refs and unrefs the WebFrame and that a WebFrame might outlive a WebCore::Frame. Feel free to do a) now to give us the time to find a solution that does not involve b).
Alp Toker
Comment 3 2008-02-17 06:26:42 PST
Lack of content is an unrelated issue, downgrading to P2. The console errors are still important (equivalent to a null dereference with optimized GTK+ builds) so need to be fixed, but we can take a bit more time over that.
Alp Toker
Comment 4 2008-02-26 21:52:13 PST
(In reply to comment #2) > Let us: > a) revert the refcount changes > b) settle for the traditional scheme that FrameLoaderClient refs and unrefs > the > WebFrame and that a WebFrame might outlive a WebCore::Frame. > > Feel free to do a) now to give us the time to find a solution that does not > involve b). > Any word on this? The console messages are getting a bit unpopular with users.
Jan Alonzo
Comment 5 2008-04-14 04:45:48 PDT
Do you guys think this is related to bug #18064?
Holger Freyther
Comment 6 2008-04-14 05:21:41 PDT
(In reply to comment #5) > Do you guys think this is related to bug #18064? Yes, it might be related to this bug. I'm pretty confident that #18411 is fixing both issues. But in both cases a reduced test-case would be appreciated, so we can really be sure the crash is gone.
Jan Alonzo
Comment 7 2008-04-14 06:51:17 PDT
Just tested with the patch at bug #18411 and the assert failed warnings are still there, so I guess they're not related.
Alp Toker
Comment 8 2008-04-19 00:26:57 PDT
Holger's recent page changes fixed this issue. Re-open bug if the issue persists.
Note You need to log in before you can comment on or make changes to this bug.