Bug 17373 - Language code in User-Agent header doesn't support 3- or 4-letter language codes
Summary: Language code in User-Agent header doesn't support 3- or 4-letter language codes
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nicholas Shanks
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-15 04:39 PST by Nicholas Shanks
Modified: 2010-06-10 15:27 PDT (History)
0 users

See Also:

Attachments
Proposed patch, v1.0 (1.39 KB, patch)
2008-02-15 04:40 PST, Nicholas Shanks 		darin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas Shanks 2008-02-15 04:39:43 PST 
ISO 639-2 (alpha 3) language codes, and the reserved four-letter locale initial position should be supported for underscore to hyphen conversion.
Comment 1 Nicholas Shanks 2008-02-15 04:40:34 PST 
Created attachment 19136 [details]
Proposed patch, v1.0
Comment 2 Darin Adler 2008-02-20 09:24:14 PST 
Comment on attachment 19136 [details]
Proposed patch, v1.0

Seems OK. What are some actual language codes we can test this with. Do we know what this does to website compatibility?

No change log.

No regression tests. Need to find a way to regression-test this.

Formatting does not match style guide: single line if statements should not have braces.

Fix seems fine with some minor problems. Benefit also seems small unless there's some actual language code that's going to come up in practice, so setting to review- to get the minor problems fixed.