17371 – [wx] Make sure we generate a unique hash value for the font cache

Bug 17371 - [wx] Make sure we generate a unique hash value for the font cache

Summary: [wx] Make sure we generate a unique hash value for the font cache

Attachments
Make sure we generate unique hash ids (1.36 KB, patch) 2008-02-14 22:15 PST, Kevin Ollivier	no flags	Details \| Formatted Diff \| Diff
Simplified version that doesn't do an unnecessary hash calculation (1.23 KB, patch) 2008-02-15 18:46 PST, Kevin Ollivier	hyatt: review+	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kevin Ollivier 2008-02-14 22:08:09 PST

Generating hash values from the result of GetNativeFontInfoDesc() sometimes leads to duplicate hash values.

Comment 1 Kevin Ollivier 2008-02-14 22:15:38 PST

Created attachment 19133 [details]
Make sure we generate unique hash ids

Fix that uses the font object's pointer as the source for the hash value.

Comment 2 Kevin Ollivier 2008-02-15 18:46:26 PST

Created attachment 19149 [details]
Simplified version that doesn't do an unnecessary hash calculation

Comment 3 Dave Hyatt 2008-02-15 19:15:10 PST

Comment on attachment 19149 [details]
Simplified version that doesn't do an unnecessary hash calculation

r=me

Comment 4 Kevin Ollivier 2008-02-15 19:29:00 PST

Landed in r30334. Thanks!