Bug 17340 - WebCore/platform/Timer.cpp fails to build with gcc 4.3
Summary: WebCore/platform/Timer.cpp fails to build with gcc 4.3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-13 02:32 PST by Bernhard Rosenkraenzer
Modified: 2008-02-13 04:28 PST (History)
0 users

See Also:

Attachments
fix (542 bytes, patch)
2008-02-13 02:36 PST, Bernhard Rosenkraenzer 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Rosenkraenzer 2008-02-13 02:32:44 PST 
../../../WebCore/platform/Timer.cpp: In function 'bool WebCore::operator<(const WebCore::TimerHeapElement&, const WebCore::TimerHeapElement&)':
../../../WebCore/platform/Timer.cpp:107: error: 'UINT_MAX' was not declared in this scope
make[1]: *** [tmp/Timer.o] Error 1


UINT_MAX is defined in <limits.h>, which isn't being #included.
Comment 1 Bernhard Rosenkraenzer 2008-02-13 02:33:28 PST 
This happens to work with older versions of gcc because

#include <limits>

used to #include <climits> as well. gcc 4.3 trims down on header interdependencies
Comment 2 Bernhard Rosenkraenzer 2008-02-13 02:36:02 PST 
Created attachment 19108 [details]
fix
Comment 3 Darin Adler 2008-02-13 04:12:58 PST 
Comment on attachment 19108 [details]
fix

We would use <limits.h> rather that <climits>.
Comment 4 Darin Adler 2008-02-13 04:28:27 PST 
Again had to remove tabs and apply the patch by hand.

Committed revision 30193.