Bug 17299 – Patch providing fully-buildable Cairo-backed Win32 WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brent Fulgham]

The attached patch updates a few spots in WebCore that are needed to build a Cairo-based Win32 WebCore.  Additional patches are being provided for the WebKit portion of the changes.

To be completely usable, this patch requires an updated WebCore.vcproj to build the Cairo-specific parts of WebCore.  A separate bug is being created to complete this work, as some thought will need to be given to the means of supporting Cairo and CG in a single solution file.

[Brent Fulgham]

Created attachment 19051 [details]
Patch for Cairo support in WebCore.

[Brent Fulgham]

Note that this bug is related to Bug #17300 (though it does not depend on its soution).

[Darin Adler]

Comment on attachment 19051 [details]
Patch for Cairo support in WebCore.

Patch looks good. Some small issues:

 #include "config.h"
+#include "PlatformString.h"
+#include "CSSValueKeywords.h"
 #include "RenderThemeWin.h"

New includes should go in a separate group. See the <http://webkit.org/coding/coding-style.html> section called "#include statements".

+        cachedDesc->firstFamily().setFamily("Lucida Grande");

Are you sure that's the right choice? I don't think that font is included by default on Windows.

[Robert Blaut]

(In reply to comment #3)
> +        cachedDesc->firstFamily().setFamily("Lucida Grande");
> 
> Are you sure that's the right choice? I don't think that font is included by
> default on Windows.
> 

On Windows there is a similar font called Lucida Sans Unicode -> http://en.wikipedia.org/wiki/Lucida_Sans_Unicode

[Darin Adler]

Comment on attachment 19051 [details]
Patch for Cairo support in WebCore.

I'll just take this and tweak it and land it.

[Brent Fulgham]

(In reply to comment #5)
> (From update of attachment 19051 [details] [edit])
> I'll just take this and tweak it and land it.
> 

Oh, thanks!  I was going to research the proper font to use; currently it doesn't really matter because the font rendering is getting hung up somewhere else.  I'm trying to debug it today as time allows.

[Darin Adler]

Comment on attachment 19051 [details]
Patch for Cairo support in WebCore.

Committed revision 30143.