Bug 17259 - Element::recalcStyle() needlessly null-checks the result of styleForElement()
Summary: Element::recalcStyle() needlessly null-checks the result of styleForElement()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-09 10:56 PST by mitz
Modified: 2008-02-09 16:17 PST (History)
0 users

See Also:


Attachments
Remove unneeded null checks (1.92 KB, patch)
2008-02-09 10:58 PST, mitz
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2008-02-09 10:56:44 PST
Element::recalcStyle() needlessly null-checks the result of styleForElement().
Comment 1 mitz 2008-02-09 10:58:09 PST
Created attachment 19019 [details]
Remove unneeded null checks
Comment 2 Sam Weinig 2008-02-09 15:58:12 PST
Comment on attachment 19019 [details]
Remove unneeded null checks

This looks good to me, but as discussed, a better word than redundant should be used to describe why the null checks aren't needed.  Just stating that styleForElement() cannot return null should be sufficient.
Comment 3 mitz 2008-02-09 16:17:05 PST
Fixed in <http://trac.webkit.org/projects/webkit/changeset/30117>.