RESOLVED FIXED 17211
MSVC7 fixes 
https://bugs.webkit.org/show_bug.cgi?id=17211
Summary MSVC7 fixes
Kevin Ollivier
Reported 2008-02-07 15:01:51 PST
Couple quick MSVC7 fixes. First, USER_TIMER_MINIMUM/MAXIMUM is not defined under MSVC 2003 SDK for some reason, and second, there seems to be a problem with the Interlocked* functions on MSVC7. Fixes are attached.
Attachments
fixing MSVC7 build (1.94 KB, patch)
2008-02-07 15:02 PST, Kevin Ollivier 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kevin Ollivier
Comment 1 2008-02-07 15:02:41 PST
Created attachment 18992 [details] fixing MSVC7 build
Alexey Proskuryakov
Comment 2 2008-02-08 05:30:31 PST
Comment on attachment 18992 [details] fixing MSVC7 build + - On MSVC7, when the Interlocked* functions are used, the ref count gets out of sync. Weird!
Adam Roben (:aroben)
Comment 3 2008-02-08 14:24:23 PST
Comment on attachment 18992 [details] fixing MSVC7 build r=me
Eric Seidel (no email)
Comment 4 2008-02-08 14:24:23 PST
Comment on attachment 18992 [details] fixing MSVC7 build This looks fine to me. I think sfalken or aroben or one of the frequent windows hackers should give it the official r+.
Eric Seidel (no email)
Comment 5 2008-02-08 14:24:45 PST
Comment on attachment 18992 [details] fixing MSVC7 build Stupid bugzilla.
Mark Rowe (bdash)
Comment 6 2008-02-09 04:01:42 PST
This was landed in <http://trac.webkit.org/projects/webkit/changeset/30108>. Kevin, can you make sure to close the bugs when you land the patches?
Note You need to log in before you can comment on or make changes to this bug.