Bug 17201 - Use RefPtr in CSSParser::parseFont() to get rid of goto silliness
Summary: Use RefPtr in CSSParser::parseFont() to get rid of goto silliness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Minor
Assignee: Nobody
URL:
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2008-02-06 14:28 PST by David Kilzer (:ddkilzer)
Modified: 2008-02-11 13:06 PST (History)
0 users

See Also:

Attachments
First attempt (3.62 KB, patch)
2008-02-10 23:31 PST, Rob Buis 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2008-02-06 14:28:33 PST 
CSSParser::parseFont() uses goto statements to release the FontValue object on early exit.  It should be using a RefPtr<FontValue> instead.
Comment 1 Rob Buis 2008-02-10 23:31:24 PST 
Created attachment 19059 [details]
First attempt

Gets rid of the goto usage in parseFont.
Cheers,

Rob.
Comment 2 David Kilzer (:ddkilzer) 2008-02-11 06:23:22 PST 
Comment on attachment 19059 [details]
First attempt

Thanks Rob!!  r=me

Please remove tabs from the ChangeLog before landing!
Comment 3 Rob Buis 2008-02-11 13:06:48 PST 
Landed in 30152.